Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAPDANCE outside Xorg #24483

Closed
andmarti1424 opened this issue Oct 13, 2024 · 6 comments
Closed

TAPDANCE outside Xorg #24483

andmarti1424 opened this issue Oct 13, 2024 · 6 comments
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.

Comments

@andmarti1424
Copy link

Hello.
I have a planck with qmk. I have a tapdance on tab key to act as a left control when held. And as a tab on single press.
TAPDANCE is working fine on my Xorg session, but it does not work on sway (wayland) nor outside X..
Is this expected? Any workaround this?
Thanks!

@lesshonor
Copy link
Contributor

lesshonor commented Oct 13, 2024

While the proposed solution is not easily usable at present due to code conflicts, see #19449 for more information/discussion about this problem.

Note that if you are using GNOME, this issue may be resolved in a later release.

@andmarti1424
Copy link
Author

While the proposed solution is not easily usable at present due to code conflicts, see #19449 for more information/discussion about this problem.

Note that if you are using GNOME, this issue may be resolved in a later release.

But where is the problem?
I don't use shift modifier. Just a tab when single pressed or ctrl modifier when held.

@lesshonor
Copy link
Contributor

lesshonor commented Oct 13, 2024

From the description of the pull request:

QMK has trouble sending modifier keys [...]

Control is also a modifier...

Anyway, there is a lot of information in that pull request including links to related issues and alternative solutions, but if you aren't interested in reading any of it you can just try setting #define TAP_CODE_DELAY to a small value (like 10) in your keymap's config.h as a workaround.

@andmarti1424
Copy link
Author

@lesshonor thank you. Im afraid that didnt change a thing. I had to redefine it cause it was already defined to 0 value.
image
Im using sway by the way. but as I said earlier, this happens also outside wayland.
Will try to #define DOUBLE_REPORT but since it was a PR that was not merged.. I expect it behave the same way.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 12, 2025
Copy link

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted question stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

2 participants