Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mistake in matrix description of the Keychron Q6 ISO encoder #20579

Closed
2 tasks
FabienFellay opened this issue Apr 26, 2023 · 1 comment · Fixed by #20582
Closed
2 tasks

[Bug] Mistake in matrix description of the Keychron Q6 ISO encoder #20579

FabienFellay opened this issue Apr 26, 2023 · 1 comment · Fixed by #20582

Comments

@FabienFellay
Copy link
Contributor

Describe the Bug

The line 105 of the file https://github.com/qmk/qmk_firmware/blob/master/keyboards/keychron/q6/iso_encoder/info.json has a wrong x coordinate (it is the same as the one of line 106): one should replace the line 105

                {"matrix":[4, 1], "x":2.25, "y":4.25},

by

                {"matrix":[4, 1], "x":1.25, "y":4.25},

Indeed, currently, both the <> touch and the z touch will be visually placed at the same location in the QMK Configurator and there is no way I can fix it from there. We have to correct this file.

Note that the Keychron Q6 ISO (no encoder) matrix description is correct.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

This issue impacts the use of the QMK Configurator: https://config.qmk.fm/#/keychron/q6/iso_encoder/LAYOUT_iso_110
The maintainer, @lalalademaxiya1, should have a look at this when time will allow it.

@adophoxia
Copy link
Contributor

Tested the recommended change you suggested myself and it does correctly show the KC_NUBS/ <> key when loading the info.json file into Configurator via Ctrl + Shift + I.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants