Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Feker IK75 wrong status LED configuration #19287

Open
2 tasks
jestercore opened this issue Dec 10, 2022 · 9 comments
Open
2 tasks

[Bug] Feker IK75 wrong status LED configuration #19287

jestercore opened this issue Dec 10, 2022 · 9 comments

Comments

@jestercore
Copy link
Contributor

Describe the Bug

Status LEDs for Windows key lock and Scroll lock are messed up and should be swapped.
At the moment when you lock Windows key - LED with "S" lights up. The same when you Scroll lock lights up "W".
That's a clear mistake.

Could you please fix it?

Keyboard Used

feker/ik75

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

https://github.com/qmk/qmk_firmware/tree/master/keyboards/feker/ik75

@HorrorTroll
Copy link
Contributor

can u specific more issue? It was running fine on my friend keebs and other people.

@jestercore
Copy link
Contributor Author

can u specific more issue? It was running fine on my friend keebs and other people.

Wrong LEDs activating for Win Lock and Scroll Lock, they are swapped out.

https://photos.app.goo.gl/WtCdnj2y5uJvJ93b9

@HorrorTroll
Copy link
Contributor

image
oh about that one, it is Feker issue not the firmware wrong anyway. They just messed up label on the top case

@jestercore
Copy link
Contributor Author

image oh about that one, it is Feker issue not the firmware wrong anyway. They just messed up label on the top case

Yes, but I think labels on case are prioritized over PCB markings.
How can it be swapped in firmware? Can I edit it and build new .hex firmware? Could you please explain how?

@HorrorTroll
Copy link
Contributor

HorrorTroll commented Dec 10, 2022

uhhh, pcb marking was been used at default for indicator. The issue on top case is problem of them, there no way to fix this.

@jestercore
Copy link
Contributor Author

uhhh, pcb marking was been used at default for indicator. The issue on top case is problem of them, there no way to fix this.

Is this really not possible to swap these LEDs in firmware? Like change two values?

@HorrorTroll
Copy link
Contributor

nope, it not how that work anyway, sorry.

@jestercore
Copy link
Contributor Author

jestercore commented Apr 9, 2023

I was managed to fix it by swapping colors for indicators in keymap:

before

bool rgb_matrix_indicators_user(void) {
    rgb_matrix_set_color(46, 0, 0, 0);
    rgb_matrix_set_color(104, 0, 0, 0);

    uint8_t red = host_keyboard_led_state().caps_lock ? 255 : 0;
    uint8_t green = host_keyboard_led_state().scroll_lock ? 255 : 0;
    uint8_t blue = keymap_config.no_gui ? 255 : 0;

after

bool rgb_matrix_indicators_user(void) {
    rgb_matrix_set_color(46, 0, 0, 0);
    rgb_matrix_set_color(104, 0, 0, 0);

    uint8_t red = host_keyboard_led_state().caps_lock ? 255 : 0;
    uint8_t **blue** = host_keyboard_led_state().scroll_lock ? 255 : 0;
    uint8_t **green** = keymap_config.no_gui ? 255 : 0;

Could you please merge this in the master?

@Siioh
Copy link

Siioh commented May 4, 2023

Thank you for providing this solution. I had the same problem, and it looks like it was still not yet applied to the master. I was able to resolve it using your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants