Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] With Autoshift Enabled, holding Enter does not send Shift+Enter #13469

Open
3 tasks
VSantillo opened this issue Jul 6, 2021 · 3 comments
Open
3 tasks

Comments

@VSantillo
Copy link

Describe the Bug

With Autoshift Enabled, holding Enter does not send Shift + Enter.

System Information

  • Keyboard: DZ60 ANSI
    • Revision (if applicable): v2
  • Operating system: MacOS
  • AVR GCC version:
    avr-gcc (Homebrew AVR GCC 8.4.0_1) 8.4.0
  • ARM GCC version:
    arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]
  • QMK Firmware version:
    0.13.2
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

When Tab is held, it is treated as a Shift + Tab. My editor has a shortcut for Shift + Tab and Shift + Enter, but I had to program in a tap dance for Shift + Enter. Not the end of the world, but I think it's inconsistent.

@zvecr
Copy link
Member

zvecr commented Jul 6, 2021

Right now its the expected behaviour, but can be overridden at the keymap level by providing your own get_auto_shifted_key implementation.

https://docs.qmk.fm/#/feature_auto_shift?id=auto-shift-per-key

Maybe it falls under NO_AUTO_SHIFT_SPECIAL, but its not a super clean behaviour to change without breaking existing users.

@VSantillo
Copy link
Author

Thanks! When I had read it earlier, I thought that the omission was unintentional since there was no explanation why.

@arlaneenalra
Copy link
Contributor

I actually came here looking for a way to pull tab out of the autoshift list while keeping the symbol characters present (for example ][=_}{ ). Would it make sense to do split the NO_AUTO_SHIFT_SPECIAL macro up to handle the symbol characters and tab/enter characters seperately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants