Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for SSD1306 OLED fade register (23h) #11433

Closed
2 of 4 tasks
Barabas5532 opened this issue Jan 4, 2021 · 2 comments
Closed
2 of 4 tasks

[Feature Request] Support for SSD1306 OLED fade register (23h) #11433

Barabas5532 opened this issue Jan 4, 2021 · 2 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@Barabas5532
Copy link

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

According to this datasheet, the SSD1306 OLED has a register that can be used for fade out. This is missing from earlier revisions of the datasheet, but it did work on the OLEDs I have (only a single pair from the same source). It would be nice if this could be used instead of the DISPLAY_OFF when the OLED times out.

I have created a branch with a prototype implementation. I've just replaced the DISPLAY_OFF and DISPLAY_ON commands with the equivalent using the fade register.

This register also supports a blink mode, but that is not so relevant for me.

@drashna
Copy link
Member

drashna commented Mar 2, 2021

Looks nice, actually.

Though, OLED_DRIVER_DISPLAY_FADE for enabling it, and OLED_DRIVER_DISPLAY_FADE_INTERVAL would probably be better names.

Feel free to open up a PR, though.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

2 participants