From bb805ff9b07932fc84d6c2c357e1f885c8e9788b Mon Sep 17 00:00:00 2001 From: Marco Pelegrini Date: Mon, 2 Dec 2024 11:19:07 -0800 Subject: [PATCH] Review comments --- keyboards/marcopad/keyboard.json | 156 +++++++++++++++---------------- keyboards/marcopad/readme.md | 2 +- 2 files changed, 79 insertions(+), 79 deletions(-) diff --git a/keyboards/marcopad/keyboard.json b/keyboards/marcopad/keyboard.json index 1b9be5514ca4..c0a8ca37c049 100644 --- a/keyboards/marcopad/keyboard.json +++ b/keyboards/marcopad/keyboard.json @@ -1,80 +1,80 @@ { - "keyboard_name": "MarcoPad", - "manufacturer": "pelegrini.ca", - "url": "https://pelegrini.ca/marcopad", - "maintainer": "Marco Pelegrini", - "bootloader": "rp2040", - "processor": "RP2040", - "diode_direction": "ROW2COL", - "features": { - "bootmagic": true, - "rgb_matrix": true - }, - "matrix_pins": { - "cols": ["GP4", "GP26", "GP27"], - "rows": ["GP15", "GP14", "GP29"] - }, - "usb": { - "device_version": "1.0.0", - "pid": "0x0000", - "vid": "0xFEED" - }, - "ws2812": { - "driver": "vendor", - "pin": "GP28" - }, - "rgb_matrix": { - "driver": "ws2812", - "animations": { - "breathing": true, - "cycle_all": true, - "cycle_left_right": true, - "cycle_up_down": true, - "rainbow_moving_chevron": true, - "dual_beacon": true, - "rainbow_beacon": true, - "pixel_rain": true, - "typing_heatmap": true, - "solid_reactive": true, - "solid_reactive_multiwide": true, - "solid_reactive_multicross": true, - "solid_reactive_multinexus": true, - "splash": true - }, - "layout": [ - { "flags": 4, "matrix": [0, 0], "x": 0, "y": 0 }, - { "flags": 4, "matrix": [0, 1], "x": 0, "y": 32 }, - { "flags": 4, "matrix": [0, 2], "x": 0, "y": 64 }, - { "flags": 4, "matrix": [1, 0], "x": 112, "y": 0 }, - { "flags": 4, "matrix": [1, 1], "x": 112, "y": 32 }, - { "flags": 4, "matrix": [1, 2], "x": 112, "y": 64 }, - { "flags": 4, "matrix": [2, 0], "x": 224, "y": 0 }, - { "flags": 4, "matrix": [2, 1], "x": 224, "y": 32 }, - { "flags": 4, "matrix": [2, 2], "x": 224, "y": 64 } - ], - "default": { - "animation": "splash", - "hue": 132, - "sat": 102, - "val": 255, - "speed": 80 - }, - "sleep": true - }, - "community_layouts": ["ortho_3x3"], - "layouts": { - "LAYOUT_ortho_3x3": { - "layout": [ - { "matrix": [0, 0], "x": 0, "y": 0 }, - { "matrix": [0, 1], "x": 0, "y": 1 }, - { "matrix": [0, 2], "x": 0, "y": 2 }, - { "matrix": [1, 0], "x": 1, "y": 0 }, - { "matrix": [1, 1], "x": 1, "y": 1 }, - { "matrix": [1, 2], "x": 1, "y": 2 }, - { "matrix": [2, 0], "x": 2, "y": 0 }, - { "matrix": [2, 1], "x": 2, "y": 1 }, - { "matrix": [2, 2], "x": 2, "y": 2 } - ] - } - } + "manufacturer": "pelegrini.ca", + "keyboard_name": "MarcoPad", + "maintainer": "Marco Pelegrini", + "bootloader": "rp2040", + "diode_direction": "ROW2COL", + "features": { + "bootmagic": true, + "rgb_matrix": true + }, + "matrix_pins": { + "cols": ["GP4", "GP26", "GP27"], + "rows": ["GP15", "GP14", "GP29"] + }, + "processor": "RP2040", + "rgb_matrix": { + "animations": { + "breathing": true, + "cycle_all": true, + "cycle_left_right": true, + "cycle_up_down": true, + "dual_beacon": true, + "pixel_rain": true, + "rainbow_beacon": true, + "rainbow_moving_chevron": true, + "solid_reactive": true, + "solid_reactive_multicross": true, + "solid_reactive_multinexus": true, + "solid_reactive_multiwide": true, + "splash": true, + "typing_heatmap": true + }, + "default": { + "animation": "splash", + "hue": 132, + "sat": 102, + "speed": 80, + "val": 255 + }, + "driver": "ws2812", + "layout": [ + {"matrix": [0, 0], "x": 0, "y": 0, "flags": 4}, + {"matrix": [0, 1], "x": 0, "y": 32, "flags": 4}, + {"matrix": [0, 2], "x": 0, "y": 64, "flags": 4}, + {"matrix": [1, 0], "x": 112, "y": 0, "flags": 4}, + {"matrix": [1, 1], "x": 112, "y": 32, "flags": 4}, + {"matrix": [1, 2], "x": 112, "y": 64, "flags": 4}, + {"matrix": [2, 0], "x": 224, "y": 0, "flags": 4}, + {"matrix": [2, 1], "x": 224, "y": 32, "flags": 4}, + {"matrix": [2, 2], "x": 224, "y": 64, "flags": 4} + ], + "sleep": true + }, + "url": "https://pelegrini.ca/marcopad", + "usb": { + "device_version": "1.0.0", + "pid": "0x0000", + "vid": "0xFEED" + }, + "ws2812": { + "driver": "vendor", + "pin": "GP28" + }, + "community_layouts": ["ortho_3x3"], + "layouts": { + "LAYOUT_ortho_3x3": { + "layout": [ + {"matrix": [0, 0], "x": 0, "y": 0}, + {"matrix": [0, 1], "x": 0, "y": 1}, + {"matrix": [0, 2], "x": 0, "y": 2}, + {"matrix": [1, 0], "x": 1, "y": 0}, + {"matrix": [1, 1], "x": 1, "y": 1}, + {"matrix": [1, 2], "x": 1, "y": 2}, + {"matrix": [2, 0], "x": 2, "y": 0}, + {"matrix": [2, 1], "x": 2, "y": 1}, + {"matrix": [2, 2], "x": 2, "y": 2} + ] + } + } } diff --git a/keyboards/marcopad/readme.md b/keyboards/marcopad/readme.md index 15c87265c53d..6bc1733f30cc 100644 --- a/keyboards/marcopad/readme.md +++ b/keyboards/marcopad/readme.md @@ -1,6 +1,6 @@ # MarcoPad -![marcopad](https://pelegrini.ca/assets/img/marcopad/hardware/macropad.png) +![marcopad](https://i.imgur.com/AnC9SeW.png) *A compact 3x3 keys macropad built with RP-2040 Zero*