Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Converter/Convert To drop down for pin_compatible defined boards #1290

Open
dunk2k opened this issue Jul 12, 2023 · 4 comments

Comments

@dunk2k
Copy link
Contributor

dunk2k commented Jul 12, 2023

Description

I do recall @zvecr mentioning something such as this in a qmk/qmk_firmware PR regarding reworking converters.

Front End:
If a keyboard in qmk_firmware repo has pin compatible defined, in info.json as pin_compatible or development_board, then a converter/"Convert To" drop down field appears in QMK configurator web front end near the Compile and Load Default buttons.

Converter drop down would contain entries respective to keyboard's pin compatible definition. Drop down entries would include a default "Do Not Convert".

Hovering cursor over the drop down field's title would show a tooltip with words to effect of convert this keyboard to a pin compatible controller.

Back End:
If a converter drop down entry, that isn't "Do Not Convert", has been selected in web front end and Compile button scriptbegins, append qmk compile command in qmk_compiler with -e CONVERT_TO=[respective user selected converter drop down entry].

@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 12, 2023

Would this be dependent on
1. qmk_api accommodating QMK converters in payload for '/v1/compile' POST method?
2. qmk_compiler knowing how to interpret converter from api payload

Edit: All of this was already complete before this request was raised qmk/qmk_firmware#18776

@daysgobye
Copy link

I want this and am happy to do the work I am 100% capable of doing it. If I can get some buy in / approval that this would be accepted. And if the core team has a way they would like to see this implemented please let me know, so I can do it right the first time.

@mobergmann
Copy link

I want this and am happy to do the work I am 100% capable of doing it. If I can get some buy in / approval that this would be accepted. And if the core team has a way they would like to see this implemented please let me know, so I can do it right the first time.

I would also love to see this feature. Are there any news for this? I couldn't find any branches/MR.

@dunk2k
Copy link
Contributor Author

dunk2k commented May 25, 2024

@daysgobye
Would you still be willing to implement this feature?

Suffice to say both myself and @mobergmann are bought into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants