Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qiskit_nature.testing does not have explicit unittests #1148

Open
mrossinek opened this issue May 2, 2023 · 1 comment
Open

qiskit_nature.testing does not have explicit unittests #1148

mrossinek opened this issue May 2, 2023 · 1 comment
Labels
type: feature request New feature or request

Comments

@mrossinek
Copy link
Member

What should we add?

The utilities provided by qiskit_nature.testing are not currently unittested as standalone methods.
#1022 adds a file to do this (for the newly method added in that PR) but the existing methods could still benefit from some extra unittests.

While they are used by other existing tests (since that is what they are built for) having explicit unittests for anything that is part of the public API seems like a good idea.
@mrossinek mrossinek added the type: feature request New feature or request label May 2, 2023
@mrossinek
Copy link
Member Author

@kevinsung since you added those utilities, would you have time to look into this?

@kevinsung kevinsung self-assigned this May 2, 2023
@kevinsung kevinsung removed their assignment Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinsung @mrossinek