Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements in the module #24

Closed
8 of 9 tasks
adekusar-drl opened this issue Mar 31, 2021 · 1 comment · Fixed by #25
Closed
8 of 9 tasks

Minor improvements in the module #24

adekusar-drl opened this issue Mar 31, 2021 · 1 comment · Fixed by #25
Assignees
Labels
type: enhancement ✨ Features or aspects to improve

Comments

@adekusar-drl
Copy link
Collaborator

adekusar-drl commented Mar 31, 2021

What is the expected enhancement?

There are minor improvements to do:

  • algorithms/init

  • NNC/NNR/VQR are missing in docstring

  • datasets

  • Return np.ndarrays, optionally one-hot encoded (remove all functions not used)

  • neural_networks/init

  • OpflowQNN missing in docstring

  • loss_functions

  • Should we rename the file loss.py to loss_functions.py?

  • Should we include the actual loss functions in the init.py to make them importable directly, e.g. "from qml.utils.lossfunctions import CrossEntropyLoss"? (currently there is only the copyright header in the loss_functions init)

  • Are we using L2LossProbability or should we remove it? Or is it tested somewhere?

  • We should extend the docstrings of the loss functions a little bit to include what exactly they are computing.

  • Did we test the KLDiv somewhere (it doesn't have a gradient implemented)?

  • Do we need softmax/stable_softmax, doesn't seem to be used anywhere, maybe remove?

@adekusar-drl adekusar-drl added the type: enhancement ✨ Features or aspects to improve label Mar 31, 2021
@stefan-woerner stefan-woerner linked a pull request Mar 31, 2021 that will close this issue
@adekusar-drl
Copy link
Collaborator Author

Datasets are fixed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Features or aspects to improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants