Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct target device components #171

Open
jyu00 opened this issue Jul 14, 2021 · 2 comments
Open

Use correct target device components #171

jyu00 opened this issue Jul 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jyu00
Copy link
Contributor

jyu00 commented Jul 14, 2021

Informations

  • Qiskit Experiments version:
  • Python version:
  • Operating system:

What is the current behavior?

In DbAnalysisResultV1 there is a required field called device_components, which defines the target components of the analysis (e.g. qubits or resonators). Currently all analysis classes just specify qubits even when they should be resonators.

Steps to reproduce the problem

What is the expected behavior?

Suggested solutions

Per @nkanazawa1989 :

some experiment, such as resonator spectroscopy #90, will need to put Resonator instead of Qubit. 
We need to generalize definition the target element, i.e. from qubits to device component. 
Otherwise frequency value measured by the resonator spectroscopy experiment will be shown as 
qubit frequency in result db. 
@jyu00 jyu00 added the bug Something isn't working label Jul 14, 2021
@dekelmeirom dekelmeirom self-assigned this Sep 15, 2021
@dekelmeirom dekelmeirom modified the milestone: Release 0.3 Sep 29, 2021
@coruscating coruscating added this to the Release 0.3 milestone Dec 8, 2021
@wshanks wshanks mentioned this issue Jan 25, 2022
4 tasks
@eggerdj
Copy link
Contributor

eggerdj commented Jan 26, 2022

Looks like BaseAnalysis bakes qubits into the device components by default. https://github.com/Qiskit/qiskit-experiments/blob/a0beb41ec0757429031e0e6e7a7855dcc72877cd/qiskit_experiments/framework/base_analysis.py#L147-L153

How about outsourcing the lines above to a method _device_components that subclasses can override?

@dekelmeirom
Copy link
Contributor

I think there are not many types of device components besides qubits and resonators, therefore generalizing these few lines to also enable resonators should be enough (like done in #387 ). By enabling only pre-determined types we can also make the searches in the DB easier.
If I am wrong, and there might be more types that we don't think of right now, I think that creating a method that other subclasses can override will indeed be a better solution.

@chriseclectic chriseclectic added enhancement New feature or request and removed bug Something isn't working labels Feb 2, 2022
@chriseclectic chriseclectic removed this from the Release 0.3 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants