From d2f088103760ace65d47a20e76dde20fc1de6e76 Mon Sep 17 00:00:00 2001 From: Will Shanks Date: Tue, 1 Mar 2022 16:21:42 -0500 Subject: [PATCH] Reverse sign of fine frequency update (#699) --- qiskit_experiments/library/calibration/fine_frequency_cal.py | 2 +- test/calibration/experiments/test_fine_frequency.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qiskit_experiments/library/calibration/fine_frequency_cal.py b/qiskit_experiments/library/calibration/fine_frequency_cal.py index cfed2d2412..c38e75b306 100644 --- a/qiskit_experiments/library/calibration/fine_frequency_cal.py +++ b/qiskit_experiments/library/calibration/fine_frequency_cal.py @@ -140,7 +140,7 @@ def update_calibrations(self, experiment_data: ExperimentData): dt = experiment_data.metadata["dt"] d_theta = BaseUpdater.get_value(experiment_data, "d_theta", result_index) - new_freq = prev_freq - d_theta / (2 * np.pi * tau * dt) + new_freq = prev_freq + d_theta / (2 * np.pi * tau * dt) BaseUpdater.add_parameter_value( self._cals, experiment_data, new_freq, self._param_name, self._sched_name, group diff --git a/test/calibration/experiments/test_fine_frequency.py b/test/calibration/experiments/test_fine_frequency.py index ac7df9ec1a..7beb808a25 100644 --- a/test/calibration/experiments/test_fine_frequency.py +++ b/test/calibration/experiments/test_fine_frequency.py @@ -86,7 +86,7 @@ def test_calibration_version(self): freq_after = self.cals.get_parameter_value(self.cals.__drive_freq_parameter__, 0) # Test equality up to 10kHz on a 100 kHz shift - self.assertAlmostEqual(freq_after, armonk_freq - freq_shift, delta=1e4) + self.assertAlmostEqual(freq_after, armonk_freq + freq_shift, delta=1e4) def test_experiment_config(self): """Test converting to and from config works"""