From 08f7cbcb034ce1ca89ec44ee6a94ddb62d471cb8 Mon Sep 17 00:00:00 2001 From: knzwnao Date: Tue, 15 Mar 2022 02:41:13 +0900 Subject: [PATCH] wording edits --- qiskit_experiments/curve_analysis/curve_analysis.py | 6 +++--- qiskit_experiments/curve_analysis/fit_models.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qiskit_experiments/curve_analysis/curve_analysis.py b/qiskit_experiments/curve_analysis/curve_analysis.py index 9791f3f741..8f193cfeed 100644 --- a/qiskit_experiments/curve_analysis/curve_analysis.py +++ b/qiskit_experiments/curve_analysis/curve_analysis.py @@ -245,10 +245,10 @@ def __init_subclass__(cls, **kwargs): super().__init_subclass__(**kwargs) # Create fit model: - # The fit model is created once when the sub-class, i.e. type, is initialized. + # The fit model is created only once when the sub-class, i.e. type, is initialized. # This removes overhead of instantiating the same fit model object multiple times. - # This impact is significant especially when user create parallel experiment instance, - # where the curve analysis subclass is instantiated multiple times. + # Its impact is significant especially when user creates a parallel experiment instance, + # where the curve analysis subclass is instantiated multiple times along with fit model. model_source = collections.defaultdict(list) for series in cls.__series__: model_source["fit_functions"].append(series.fit_func) diff --git a/qiskit_experiments/curve_analysis/fit_models.py b/qiskit_experiments/curve_analysis/fit_models.py index ec66c5fc35..eb03f2b972 100644 --- a/qiskit_experiments/curve_analysis/fit_models.py +++ b/qiskit_experiments/curve_analysis/fit_models.py @@ -50,7 +50,7 @@ class FitModel(ABC): .. math:: - F(x, \Theta) = F_1(x_0, \Theta_1) \oplus F_2(x_1, \Theta_2) \\ + F(x, \Theta) = F_1(x_0, \Theta_1) \oplus F_2(x_1, \Theta_2) \ = F(x_0 \oplus x_1, p_0, p_2, p_3). This function might be called from the scipy curve fit algorithm