Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel filtering/ordering to pulse Schedule -> Signal converter #54

Closed
DanPuzzuoli opened this issue Nov 11, 2021 · 1 comment · Fixed by #59
Closed

Add channel filtering/ordering to pulse Schedule -> Signal converter #54

DanPuzzuoli opened this issue Nov 11, 2021 · 1 comment · Fixed by #59
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DanPuzzuoli
Copy link
Collaborator

What is the expected behavior?

Connected to #53.

Update the converter to include optional argument channels, specifying a list of channels as strings e.g. ['D0', 'D2', 'U0'], which modifies the behaviour of the function to:

  • Filter out channels not included in the list.
  • Return signals in a list given by the ordering in channels.
@DanPuzzuoli DanPuzzuoli added the enhancement New feature or request label Nov 11, 2021
@DanPuzzuoli
Copy link
Collaborator Author

We also need to add test cases for this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants