Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about sampling rate when using ShiftFrequency and SetFrequency in pulse schedules #241

Closed
DanPuzzuoli opened this issue Jul 11, 2023 · 0 comments · Fixed by #242

Comments

@DanPuzzuoli
Copy link
Collaborator

An issue arose here when SetFrequency and ShiftFrequency were used to shift a channel frequency well away from what was specified in the channel_carrier_freqs argument to Solver.

The specified channel frequency couldn't be represented digitally with the given dt, and the simulations therefore produced strange results.

@nkanazawa1989 suggested raising a warning in the schedule interpretation step when the difference between the schedule frequency and the channel_carrier_freqs frequency is larger than the Nyquist frequency (and therefore can't be accurately represented). One minor technical issue with adding this is that this code can be compiled with JAX, so we'll need to take some technical care with handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant