Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx theme #78

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Sep 26, 2023

Summary

Updates to new Ecosystem theme.

For more information: Qiskit/qiskit_sphinx_theme#232

@fretchen
Copy link
Collaborator

Is it possible that this update also requires us to update the requirements for python to be >=3.8 ?

@arnaucasau
Copy link
Contributor Author

@fretchen Yes, in order to use the new Sphinx theme (version 1.16) it requires at least python 3.8

@arnaucasau arnaucasau marked this pull request as draft September 27, 2023 07:39
@fretchen
Copy link
Collaborator

In this case I do not see any reason to keep python-3.7 here. Could you update this ?

Optional question: Is there any upper limit on python versions against which we can test within qiskit-community? In other words. Could we update the tests to work for python 3.8 to 3.11 or something like this ?

@Eric-Arellano
Copy link
Collaborator

Yes, in order to use the new Sphinx theme (version 1.16) it requires at least python 3.8

To clarify, Sphinx is a dev requirement. It has no impact on end users. But indeed, modern Sphinx requires 3.8+. Either way, Python 3.7 is now EOL (end of life), so it's a good idea to drop it.

Could you update this ?

@arnaucasau I recommend you have a dedicated PR that drops Python 3.7 as a precursor to this PR. You'll want to update all the GitHub actions files, along with the project metadata:

"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",

python_requires=">=3.6",

In other words. Could we update the tests to work for python 3.8 to 3.11 or something like this ?

Qiskit should work well with 3.11, the latest stable release. I would recommend testing 3.8 and 3.11 in CI, and not 3.9 anymore. Given Python's backward compatibility, 3.9 and 3.10 should work if 3.8 and 3.11 also work. @arnaucasau this would be good to include in your PR to drop Python 3.7.

@arnaucasau arnaucasau marked this pull request as ready for review October 18, 2023 08:41
Copy link
Collaborator

@fretchen fretchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to me if you could add the reno file.

@Eric-Arellano
Copy link
Collaborator

Almost good to me if you could add the reno file.

Saying what? This PR now only changes the docs theme, which has little user impact. Arnau changed the Python version separately in #82.

@fretchen
Copy link
Collaborator

fretchen commented Oct 20, 2023 via email

Copy link
Collaborator

@fretchen fretchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eric-Arellano
Copy link
Collaborator

Thanks, @fretchen! Arnau doesn't have write access so will need a maintainer to merge this.

@fretchen fretchen merged commit 1a9edee into qiskit-community:main Oct 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants