-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx theme #78
Update sphinx theme #78
Conversation
Is it possible that this update also requires us to update the requirements for python to be >=3.8 ? |
@fretchen Yes, in order to use the new Sphinx theme (version 1.16) it requires at least python 3.8 |
In this case I do not see any reason to keep python-3.7 here. Could you update this ? Optional question: Is there any upper limit on python versions against which we can test within |
To clarify, Sphinx is a dev requirement. It has no impact on end users. But indeed, modern Sphinx requires 3.8+. Either way, Python 3.7 is now EOL (end of life), so it's a good idea to drop it.
@arnaucasau I recommend you have a dedicated PR that drops Python 3.7 as a precursor to this PR. You'll want to update all the GitHub actions files, along with the project metadata: Lines 46 to 47 in 36e62d7
Line 56 in 36e62d7
Qiskit should work well with 3.11, the latest stable release. I would recommend testing 3.8 and 3.11 in CI, and not 3.9 anymore. Given Python's backward compatibility, 3.9 and 3.10 should work if 3.8 and 3.11 also work. @arnaucasau this would be good to include in your PR to drop Python 3.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to me if you could add the reno file.
Saying what? This PR now only changes the docs theme, which has little user impact. Arnau changed the Python version separately in #82. |
Ok. I see your point.
Eric Arellano ***@***.***> schrieb am Do. 19. Okt. 2023 um
21:52:
… Almost good to me if you could add the reno file.
Saying what? This PR now only changes the docs theme, which has little
user impact. Arnau changed the Python version separately in #82
<#82>.
—
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7QEWUGHKYPEEVJUI4G57DYAGAHJAVCNFSM6AAAAAA5H2V2NOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGYYTGNJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks, @fretchen! Arnau doesn't have write access so will need a maintainer to merge this. |
Summary
Updates to new Ecosystem theme.
For more information: Qiskit/qiskit_sphinx_theme#232