Remove remaining qiskit.org links #152
Conversation
Eric-Arellano
requested review from
Cryoris,
woodsp-ibm and
ElePT
as code owners
Pull Request Test Coverage Report for Build 7888484746Details
💛 - Coveralls |
|
Thanks Eric, I edited the main entry above to have it close off the issue related to sorting these final links - they needed a little more attention than the simple find/replace of the other links to ecosystem hence the separate issue. When I did those other links I left any links in prior release notes stay as-is and rely on redirection. Reason being I backported those changes, and I imagine doing the same with this, to be able to republish the docs which we do off stable. But there, because backporting PRs/fixes is ongoing, there is logic that looks at the dates as compared to release tags and omits any release notes that for changes that it deems have not yet been released, so we can publish the docs at any time, not just at release points. I think editing that note will cause it to be dropped if docs are published now - I know this happened in the past which is why I left them alone. |
| @@ -19,5 +19,5 @@ prelude: | | |||
| any deprecated algorithm function. | |||
|
|
|||
| The decision to migrate the :mod:`qiskit.algorithms` module to a | |||
| separate package was made to clarify the purpose of `Qiskit <https:\\qiskit.org>`_ and | |||
| separate package was made to clarify the purpose of `Qiskit <https://www.ibm.com/quantum/qiskit>`__ and | |||
There was a problem hiding this comment.
See the comment I put earlier that included an observation around changing release notes. My thought would be to revert this.
There was a problem hiding this comment.
Oh hm. The tricky thing is that the original URL is broken because it uses \\ rather than //. Any ideas what we should do, like if we can adjust the release notes logic? I'm fine reverting this if you prefer.
There was a problem hiding this comment.
Yeah, I noticed the \\ in your change - I saw from what is published that it does end up making a link out of it, of sorts, ends up with a 404 is you click it.
The script that checks the notes - I know we messed around with it for some time so as we could publish the docs at any time and not pull in notes that had not yet been released.
For me the easiest thing, assuming we want to have all the other changes published now, ie backport and deploy the docs again, would be to revert the change. What I think would be doable is to fix this (and any others) in main branch which I think will be ok - i.e. a separate PR not backported. The intent was to have a release not too long after Qiskit 1.0 comes out so it would be part of that and get updated when the docs are deployed for that.
woodsp-ibm
added
documentation
(cherry picked from commit 652ad46)
Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: Steve Wood <[email protected]>
Closes #149