Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit test as toffoli is deprecated #122

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Update unit test as toffoli is deprecated #122

merged 4 commits into from
Jan 17, 2024

Conversation

woodsp-ibm
Copy link
Member

Summary

Fixes #111 and changes to using ccx from toffoli

Details and comments

Addresses this deprecation that has been occurring in CI

/home/runner/work/qiskit-algorithms/qiskit-algorithms/test/gradients/test_estimator_gradient.py:388: DeprecationWarning: The method qiskit.circuit.quantumcircuit.QuantumCircuit.toffoli() is deprecated as of qiskit 0.45.0. It will be removed no earlier than 3 months after the release date. Use QuantumCircuit.ccx as direct replacement.

@coveralls
Copy link

coveralls commented Jan 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7555044272

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.578%
Totals Coverage Status
Change from base Build 7555033149: 0.0%
Covered Lines: 6470
Relevant Lines: 7143
💛 - Coveralls

ElePT
ElePT approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@mergify mergify bot merged commit c598e79 into qiskit-community:main Jan 17, 2024
18 of 20 checks passed
@woodsp-ibm woodsp-ibm deleted the fix_gradient_test branch January 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@Cryoris Cryoris Awaiting requested review from Cryoris Cryoris is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/gradients/test_estimator_gradient.py needs updating
3 participants
@woodsp-ibm @coveralls @ElePT