Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ridge Regressor Precision Errors #193

Open
Oddant1 opened this issue Jun 26, 2020 · 0 comments
Open

Ridge Regressor Precision Errors #193

Oddant1 opened this issue Jun 26, 2020 · 0 comments
Labels
bug-sev:1|negligible bug-type:4|retraction Incorrect or invalid results produced.

Comments

@Oddant1
Copy link
Member

Oddant1 commented Jun 26, 2020

Bug Description
The Ridge Regressor tests are off by relatively small amounts in some environments causing test failure. Busywork is unaffected, and @nbokulich was unable to reproduce the failures. @thermokarst and I got the test failures on qiime2-2020.2, qiime2-2020.6, and latest dev (as of this issue opening) environments.

Steps to reproduce the behavior

  1. Run the q2-sample-classifier tests (run using py.test --pyargs q2_sample_classifier not make test if attempting to test a specific conda environment and not currently checked out source)
  2. Possibly observe something resembling the below screenshot

Expected behavior
The tests should pass in all environments

Screenshots
image

Computation Environment
Myself

  • OS: Linux Mint 19.3
  • QIIME 2: 2020.2, 2020.6, latest dev

@thermokarst

  • OS: Darwin
  • QIIME 2: 2020.2, 2020.6

Comments

  1. @nbokulich said this is a pretty minor issue due to the relatively small discrepancies between result and expected result as well as the fact the Ridge Regressor is unused.
  2. Possibly caused by recent sklearn changes to Ridge (see reff).
  3. Query why this issue only occurs in some environments.

References

  1. https://scikit-learn.org/stable/whats_new/v0.23.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-sev:1|negligible bug-type:4|retraction Incorrect or invalid results produced.
Projects
None yet
Development

No branches or pull requests

1 participant