Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve envelope snap #25

Open
qiemem opened this issue Nov 14, 2020 · 0 comments
Open

Improve envelope snap #25

qiemem opened this issue Nov 14, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@qiemem
Copy link
Owner

qiemem commented Nov 14, 2020

Been discussing this in PM with MW user autopoiesis.

Their suggestion has been to tweak WarpPhase from const float a = 128.0f * curve * curve; to const float a = 128.0f * curve * curve * max(1.0f, 10.0f * curve);, which makes the curve steeper at the last like third (er... sixth) of the pot. One thing here is that WarpPhase is used in a bunch of places, so I have to double check that that doesn't mess anything up.

One thing I've been interested in doing as well is removing the LPF from ramps in envelopes, which is what causes amplitude to drop with short attacks.

This is going to take some time to just play with things and see what feels good.
@qiemem qiemem added enhancement New feature or request good first issue Good for newcomers labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qiemem