Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: If only one file is needed, don't bother creating the zip file #35

Closed
thibaultmol opened this issue Mar 19, 2024 · 3 comments
Closed

Comments

@thibaultmol
Copy link

No description provided.

@qgustavor
Copy link
Owner

Pull requests are welcome. Relevant code is here: https://github.com/qgustavor/mkv-extract/blob/main/src%2Froutes%2F%2Bpage.svelte#L98

@qgustavor
Copy link
Owner

qgustavor commented Mar 26, 2024

Things to fix:

  • Rename startZipExtraction to startZipCreation. IDK why I named it wrong 🤷
  • Add a condition here to check if there's just a single stream selected, then handle this case separately in other function.

Code is kinda complex because, in order to reduce memory load, it tries to handle stream extraction by streaming the zip using streamsaver (or using the File Access API, which stores the extracted files direct to the file system without requiring a zip).

@qgustavor
Copy link
Owner

I forgot to fix the function name. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants