-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More work on settings editor #59006
More work on settings editor #59006
Conversation
3nids
commented
Oct 8, 2024
•
edited
Loading
edited
- move QgsSettingsEditorWidgetWrapper to core
- allow to specify a specific editor for a setting
- fix crash with use of PyQgsSettingsEntryEnumFlag in settings tree widget
- Python implementation of enum settings editor widget wrapper (df21a64)
otherwise, QgsSettingsEditorWidgetRegistry is creating a wrapper for this setting type and expects the cpp implemetnation (QgsSettingsEntryBaseTemplate and not QgsSettingsEntryBase)
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6builds of this PR for testing. |
I'm -1 to this -- it's definitely a GUI focused class, and is full of qwidget references. Why should it be in core? |
To be able to set an editor for a setting (and avoid creating a registry for this). It follows the same logic than There is no GUI includes in the header, and only |
That still screams of bad API to me. I personally think a registry in the GUI lib would be the correct approach
Actually, it's in GUI. The field config class is in core but that doesn't directly reference widgets at all |
OK, I'll have another look. In the mean time, I opened another PR with the still relevant stuff. |