Block header repo removed #2286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
approved these changes
Nov 29, 2024
Harrm
requested changes
Dec 2, 2024
| @@ -60,7 +60,7 @@ namespace kagome::blockchain { | |||
| outcome::result<primitives::BlockHash> putBlockHeader( | |||
| const primitives::BlockHeader &header) override; | |||
|
|
|||
| outcome::result<std::optional<primitives::BlockHeader>> getBlockHeader( | |||
| outcome::result<primitives::BlockHeader> getBlockHeader( | |||
There was a problem hiding this comment.
It should be the other way around, BlockHeaderRepository should return an optional header. However, it's hard to refactor it now since it's used in a mighty lot of places. So here where it's already done correctly changing it to the worse BlockHeaderRepository interface is not supported by me.
There was a problem hiding this comment.
In many (if not all) cases nullopt result was considered as an error but processed outside. It's much more simple to return block_not_found error right from this function.
There was a problem hiding this comment.
Added tryGetBlockHeader to block_storage so as unit tests for both get and tryGet methods
ErakhtinB
force-pushed
the
2255-enhancement-refactor-block-tree-and-header-repo
branch
3 times, most recently
from
f1d8bcd to
ad8b83b
Compare
ErakhtinB
force-pushed
the
2255-enhancement-refactor-block-tree-and-header-repo
branch
from
18554b8 to
23eef0b
Compare
…factor-block-tree-and-header-repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Closes #2255
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: