Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202411 ffmpeg #1833

Open
wants to merge 152 commits into
base: master
Choose a base branch
from
Open

Feature/202411 ffmpeg #1833

wants to merge 152 commits into from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Nov 16, 2024

PR Details

Description / Motivation and Context

This pull request includes several changes to the starsky project, focusing on refactoring namespaces, updating dependencies, and adding new functionalities. The most important changes include refactoring namespaces for consistency, updating the ExportService class, and adding new methods for zip file creation and status checking.

Refactoring and Namespace Updates:

  • Refactored namespaces in GeoBackgroundTask, GeoCli, DiskStorageHealthCheck, and UpdateImportTransformations files for consistency. [1] [2] [3] [4]

ExportService Enhancements:

  • Added new methods CreateZip and StatusIsReady to the ExportService class for handling zip file creation and status checking. [1] [2] [3]
  • Reordered and updated dependencies in ExportService to improve readability and maintainability. [1] [2]

Thumbnail and Logging Improvements:

  • Updated thumbnail generation calls to use GenerateThumbnail instead of CreateThumbAsync in ExportService.
  • Added logging for exceptions in DiskStorageHealthCheck to improve error tracking. [1] [2]

Dependency Injection and Constructor Updates:

  • Updated constructors to include new dependencies and reordered parameters for better clarity in GeoBackgroundTask, GeoCli, and DiskStorageHealthCheck. [1] [2] [3] [4] Ff2aaba6L17R18)

These changes collectively enhance the functionality, readability, and maintainability of the starsky project.

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
# Conflicts:
#	starsky-tools/build-tools/.gitignore
#	starsky-tools/build-tools/download-mirror.sh
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
qdraw added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnails for h.264/mp4 files
1 participant