Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise if named vector not found in local mode while upsert #813

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

hh-space-invader
Copy link
Contributor

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit cd85059
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/671206aa75475d000832bf53
😎 Deploy Preview https://deploy-preview-813--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hh-space-invader hh-space-invader changed the title fix: Raise if named vector not found in local mode fix: Raise if named vector not found in local mode while upsert Oct 15, 2024
@joein
Copy link
Member

joein commented Oct 16, 2024

We actually allow to pass an empty vector config, we don't want to raise an exception in this case.
We want to raise an exception if there is an attempt to upsert (or do any other operation) with a vector name which was not specified during collection creation.

@joein joein force-pushed the TSK-811-raise-error-undeclared-vector-name-local-mode branch from cdc374c to cd85059 Compare October 18, 2024 06:56
@joein joein merged commit b1bd522 into dev Oct 18, 2024
14 checks passed
joein pushed a commit that referenced this pull request Oct 29, 2024
* fix: Raise if named vector not found in local mode

* fix: Raise if named vector not found in local mode while upsert

* chore: Added test case
@hh-space-invader hh-space-invader deleted the TSK-811-raise-error-undeclared-vector-name-local-mode branch October 30, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants