Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix prefetch conversion, fix local mode query batch points offse… #812

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

joein
Copy link
Member

@joein joein commented Oct 14, 2024

Two things were broken:

  1. In local mode in query_batch_points during iteration over requests we were passing to local_collection.query_points method offset which could be None, however, it does not correspond to the interface of local_collection.query_points which accepts only int offset
  2. QueryRequest conversion was broken because it was not not properly tested. We missed a case when QueryRequest.prefetch is a single object and not a list, grpc.QueryPoints, in its turn, accepts only list of prefetches.

@joein joein requested review from generall and coszio October 14, 2024 21:40
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 5bef804
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/670d8fd9b729790008bd9bfd
😎 Deploy Preview https://deploy-preview-812--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein merged commit 5897726 into dev Oct 15, 2024
14 checks passed
joein added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants