Fix grpc payload index params #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
coszio
approved these changes
Sep 13, 2024
| client.create_payload_index(COLLECTION_NAME, "bool", models.PayloadSchemaType.BOOL) | ||
| client.create_payload_index(COLLECTION_NAME, "datetime", models.PayloadSchemaType.DATETIME) | ||
| client.create_payload_index( | ||
| COLLECTION_NAME, "keyword", models.PayloadSchemaType.KEYWORD, wait=True |
There was a problem hiding this comment.
I assume all these wait=true are added now because of the new non-blocking payload index creation 👍
Comment on lines
+2196
to
+2203
| if prefer_grpc: | ||
| rest_client = QdrantClient() | ||
| _ = rest_client.get_collection(COLLECTION_NAME).payload_schema | ||
| payload_schema = client.get_collection(COLLECTION_NAME).payload_schema | ||
| assert payload_schema["integer_parametrized"].params.lookup is True | ||
| assert payload_schema["integer_parametrized"].params.range is False | ||
| assert payload_schema["integer_parametrized"].params.is_principal is False | ||
| assert payload_schema["integer_parametrized"].params.on_disk is True |
There was a problem hiding this comment.
Just discussed this part in chat:
This is being asserted against the results of rest client, because this is the kind of behavior that would fail before. So this is in the spirit of a regression test.
joein
added a commit
that referenced
this pull request
Sep 16, 2024
* fix: update grpc parametrized payload index * fix: optional lookup and range for integer payload index * tests: add tests * fix: remove updates which are too early for the time * chore: add newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc client used to ignore such params as on_disk and is_tenant for parametrized payload indices, only rest client worked
Integer payload index params such as lookup and range used to be mandatory in rest, however, grpc could omit those params.
This behaviour was leading to an exception, when one tried to get collection info via a rest client for a collection with payload indices created via grpc client