Fix gRPC conversion for sparse search batch #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
agourlay
changed the title
generall
approved these changes
Feb 8, 2024
joein
approved these changes
Feb 8, 2024
| @@ -1955,23 +1955,26 @@ def convert_batch_vector_struct( | |||
| @classmethod | |||
| def convert_named_vector_struct( | |||
| cls, model: rest.NamedVectorStruct | |||
| ) -> Tuple[List[float], Optional[str]]: | |||
| ) -> Tuple[List[float], Optional[grpc.SparseIndices], Optional[str]]: | |||
| if isinstance(model, list): | |||
There was a problem hiding this comment.
I am a little bit confused by our naming...
Why do we have List[StrictFloat] in NamedVectorStruct :(
Code is correct though 👍
There was a problem hiding this comment.
Anonymous named vector #legacy
joein
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Fix gRPC convertion for sparse search batch * fix conversion & add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the gRPC conversion for batch search requests containing sparse vectors.