Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forbid nan in payload in local mode to restore congruence #397

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

joein
Copy link
Member

@joein joein commented Dec 8, 2023

@joein joein requested a review from generall December 8, 2023 14:29
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit ee8828a
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/6573285d3f0b620008e36bf1
😎 Deploy Preview https://deploy-preview-397--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@generall
Copy link
Member

generall commented Jan 4, 2024

one extra serialization is too expensive

@joein
Copy link
Member Author

joein commented Jan 4, 2024

it is for local mode only

@joein joein merged commit a29d632 into dev Jan 4, 2024
14 checks passed
@generall generall deleted the forbid-upsert-nan-in-local-mode branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants