Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fastembed version from 0.1.1 to 0.2.1 (latest) #486

Closed
geetu040 opened this issue Feb 8, 2024 · 3 comments
Closed

Upgrade fastembed version from 0.1.1 to 0.2.1 (latest) #486

geetu040 opened this issue Feb 8, 2024 · 3 comments

Comments

@geetu040
Copy link
Contributor

geetu040 commented Feb 8, 2024

Currently, qdrant-client uses fastembed version 0.1.1 however there is a latest version of fastembed 0.2.1 available out there.

Why should it be upgraded?

version 0.1.1 is outdated for qdrant as the latest version 0.2.1 has brough many changes in structure of code and efficiency
There have been following changes by going from 0.1.1 to 0.2.1 in fastembed

  • use "with" to open JSON files
  • HuggingFace download support for FlagEmbedding
  • chore: patch for new Xenova Jina source
  • feat: Support xenova/multilingual-e5-large, xenova/paraphrase-multilingual-mpnet-base-v2
  • Refactoring of internal structure
  • Refactor: Introduce experiments dir, README changes
  • Support Python v3.12
  • Simplify imports
  • Fix query to align with Qdrant mixin usage
  • Make 0.2.1 Release + Update docs

How to change

This can be changed easily by replacing the previous version 0.1.1

fastembed = [
    { version = "0.1.1", optional = true, python = "<3.12" }
]

With the latest version 0.2.1

fastembed = [
    { version = "0.2.1", optional = true, python = "<3.12" }
]

Test Cases

I have run test cases on qdrant with fastembed of both versions to see if any piece of code is affected

Failing Test: tests/test_fast_embed.py

FAILED tests/test_fast_embed.py::test_set_model - AssertionError: assert False

Next Step

If this issue sounds valid, I'll be happy to investigate the failing test case and upgrade to the latest version

@joein
Copy link
Member

joein commented Feb 9, 2024

Hm, thanks for pointing out the failing test

Updating version is not the only thing we need to do after the refactoring of fastembed which has been done though

@geetu040
Copy link
Contributor Author

geetu040 commented Feb 9, 2024

@joein , I was trying to solve this issue from fastembed qdrant/fastembed#95.
Should I wait for fastembed to be upgraded to latest version, or work on currently support version (0.1.1)?

@geetu040
Copy link
Contributor Author

geetu040 commented Mar 6, 2024

upgraded in #493

@geetu040 geetu040 closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants