Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow WIREGUARD_PRIVATE_KEY to be specified via a secret file #614

Closed
Sn0wCrack opened this issue Sep 12, 2021 · 7 comments

Comments

@Sn0wCrack
Copy link

Sn0wCrack commented Sep 12, 2021

What's the feature? 🧐

Allow WIREGUARD_PRIVATE_KEY to be specified via a Docker Compose secret file.

Optional extra information 🚀

I usually like to do this so I can have any sensitive data I'd normally put in my docker-compose file in a permission controlled directory.

@jathek
Copy link

jathek commented Sep 13, 2021

Also WIREGUARD_PRESHARED_KEY and WIREGUARD_ADDRESS, I would think.

@qdm12
Copy link
Owner

qdm12 commented Sep 13, 2021

  • WIREGUARD_PRIVATE_KEY yes
  • WIREGUARD_PRESHARED_KEY I guess so
  • WIREGUARD_ADDRESS meh not really, an attacker can't do much with it anyway right?

Also why do you guys see an interest in using files instead of env variables? Sensitive variables are unset at start once read in memory, so the only place they are vulnerable is in your e.g. docker-compose.yml... which is also a file. And for more advanced systems like K8s, I think you can specific a secret file to be plugged in as env variable 🤔 Just being curious! Thanks!

@Sn0wCrack
Copy link
Author

Sn0wCrack commented Sep 14, 2021

Also why do you guys see an interest in using files instead of env variables? Sensitive variables are unset at start once read in memory, so the only place they are vulnerable is in your e.g. docker-compose.yml... which is also a file. And for more advanced systems like K8s, I think you can specific a secret file to be plugged in as env variable 🤔 Just being curious! Thanks!

Honestly you're right, I could just separate out all of my variables into a separate environment file the same way the secrets files work on my system.

@jathek
Copy link

jathek commented Sep 15, 2021

Also why do you guys see an interest in using files instead of env variables? Sensitive variables are unset at start once read in memory, so the only place they are vulnerable is in your e.g. docker-compose.yml... which is also a file. And for more advanced systems like K8s, I think you can specific a secret file to be plugged in as env variable 🤔 Just being curious! Thanks!

Removing sensitive items from my default .env means other containers won't see the variables. I could use an .env specifically for gluetun, but having separate files also lets me write to a file from command-line easily and change the value without messing around with nano.

@qdm12
Copy link
Owner

qdm12 commented Jul 22, 2023

See #1348 (comment) I'll get to it soon.

@qdm12
Copy link
Owner

qdm12 commented Apr 28, 2024

This is possible with WIREGUARD_PRIVATE_KEY_SECRETFILE now, thanks for your patience!

@qdm12 qdm12 closed this as completed Apr 28, 2024
Copy link
Contributor

Closed issues are NOT monitored, so commenting here is likely to be not seen.
If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project
which became too popular to monitor issues closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants