-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display feeds as tree in RSS downloader #18440
base: master
Are you sure you want to change the base?
Conversation
It would be nice to see something different from an empty space. Maybe the *nix-like name of the root folder
👍 |
Exactly. It would be too superfluous in this place. |
Should I do a rebase or what to remove the trailing spaces? |
It's better to rebase. |
be40e96
to
a7d4c16
Compare
@Pioooooo |
Sorry, I am not familiar with GitHub pull requests and it is now ready for review I guess. |
@Pioooooo can you rebase ? |
This allows for applying rules to all feeds. Closes qbittorrent#1805.
Also add "/" as root folder path name, set root folder default expanded.
a7d4c16
to
46eb984
Compare
@luzpaz I think it's done now. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I haven't tested but this looks cleaner. Anyone who uses RSS often care to test and weigh-in ? |
This PR changes the RSS downloader dialog to use a tree for its feed list.
It is annoying if there are a lot of RSS feeds to be selected. By using a tree display it reduces this one-by-one selection effort and is more organized and consistent with the RSS reader feed list.
Closes #16802, #1805.
Currently not adding icons for the tree as the previous feed list didn't, but maybe it is better to display one to indicate one is a folder or feed?
Also for the root folder is there need for a name?