Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hotkey for Collapse/Un-collapse results while navigating #9

Open
FelipeRearden opened this issue Jan 22, 2022 · 4 comments

Comments

@FelipeRearden
Copy link

FelipeRearden commented Jan 22, 2022

Hello @qawatake !!!!!

I´m gonna try to explain this FR with my poor english

This my default search parameters: as you can see I let collapse results ON.
0

1- I start to navigate inside the results using CRTL+N and CRTL+P

2- You can see that I have more than one match for the same note 4 : 42 : 4 : 8

3- This way I wanna see the matches inside the a specific note: for example this one below

1

4- To to this I have to click WITH THE MOUSE in the arrow on the left side of the screen (this is my FR)

2

My FR

My FR is related to item 4. Is it possible to define a hotkey to do this movement of open/close the content ?

My suggestion would be CRTL+1

I don´t know if is feasible. But would be AMAZING to be able to do this with the keyboard 🙏 🙏 🙏

@qawatake
Copy link
Owner

I will try to investigate if your requested feature is possible.
But this is a lower priority than #6 (comment).

@FelipeRearden
Copy link
Author

FelipeRearden commented Jan 23, 2022

I will try to investigate if your requested feature is possible.

Thank you very much for trying!!! Let's hope it's possible 🙏

But this is a lower priority than #6 (comment).

Okay @qawatake !!!!

I think it's the best strategy!

Have a great day!!!

@qawatake
Copy link
Owner

@FelipeRearden

Could you check #6 (comment)?
I believe the new feature will be enough for you, too.

@FelipeRearden
Copy link
Author

FelipeRearden commented Jan 24, 2022

Could you check #6 (comment)?

I was testing 3.0.0 when I saw your message :)

Woooow I loved it's absolutely fantastic !!!!!

Thanks you very much for .highlight-search-match and .focus-search-match would be amazing to decorate this information!

TAB is absolutely fantastic !!!!!!!!!!!

As I said manual view is 💪!!!!!!

I believe the new feature will be enough for you, too.

I'm gonna be 100% honest as I always are when testing beta plugins. Because its important for the developer when deciding what to do or what not to do or when to do :)

In my humble opinion, would be amazing to have the keyboard hotkey to open/close that little arrow to check the content before hitting CRTL+SPACE.

  • it just feels right to check the matches before decide to open the manual view

BUT what you did is AMAZING and I'm pretty happy to be able to navigate and have the matches highlighted !!!! It brings a whole new level to Obsidian (I cant see myself searching anymore without this plugin !)

Please feel free to close this issue or to keep open for a time in the future.

Thank you very much for this amazing feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants