-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute orientation similarity map from the n best near matches per map pixel #51
Comments
Do you have a reference to the paper in which they described this? I only ask because I'm pretty sure I've read it but I can't find it right now... |
Of course: Marquardt, Katharina, De Graef, Marc, Singh, Saransh, Marquardt, Hauke, Rosenthal, Anja, Koizuimi, Sanae: Quantitative electron backscatter diffraction (EBSD) data analyses using the dictionary indexing (DI) approach: Overcoming indexing difficulties on geological materials , American Mineralogist 102(9), 1843–1855, 2017. DOI: https://doi.org/10.2138/am-2017-6062 |
Ok right - I was running a microscope with Katharina last week... probably should have known that... |
Wow, there you go! I'm a big fan of that paper. |
I think that this remains on the roadmap with relatively high priority, but I also think there are enough other items in the 0.5.0 milestone that are higher priority, therefore assigning to v0.6.0 |
Yeah, we want this for assessing pattern comparisons in kikuchipy. But not immediately, so happy to wait. |
The kikuchipy PR pyxem/kikuchipy#234 contains calculation of the orientation similarity map from a 3D map with 2D navigation shape and n number of indices per navigation point, the indices pointing to triplets of Euler angles in a 1D Euler angle array. It was decided (off GitHub yesterday) that this code would be merged into kikuchipy in the |
To confirm, I think we will eventually want |
Agree |
this is implemented in kikuchipy (kikuchipy.indexing.orientation_similarity_map) by @onatlandsmyr. either i or him and i will move it to orix after we have released a v0.3 of kikuchipy in december. |
We have computation of orientation similarity from indices into a simulation dictionary (as used by e.g. EMsoft) in kikuchipy: https://github.com/pyxem/kikuchipy/blob/master/kikuchipy/indexing/orientation_similarity_map.py. The plan is to move that functionality into a |
EMsoft provides the orientation similarity metric (OSM). From their wiki:
This should be implemented as a method in the
CrystalMap
class, I think.EMsoft implementation: EBSDgetOrientationSimilarityMap (https://github.com/EMsoft-org/EMsoft/blob/f5e6c8a5cb186478f5d34597708d4962f245a794/Source/EMsoftHDFLib/commonmod.f90#L335).
I think it should be implemented as two tools, the second using the first:
The text was updated successfully, but these errors were encountered: