-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Sanic 20.3.0 #4
Comments
I was about to open a proper pull request, but realized midway that it's not worth it considering the repository is not maintained. I would suggest migrating to sanic_session using the in-memory session interface. |
Sorry about the hiatus. |
No need to apologize! But a new release with this fix would be highly appreciated.
As the owner of this project, you should be able to reopen the PR yourself. |
@brechtm because PR #5 is broken: hard-coded session object name and inconsistency of object property vs dict element, and the new context type, types.SimpleNamespace does not have dict-like interface, etc. so I actually wrote a fix myself, including updated documentation, code example, and tests. Then I found out the test client switch from requests to httpx, and that breaks the tests, e,g |
Now that I pushed the fix into master, close this one. |
This change breaks Sanic-CookieSession: sanic-org/sanic#1801
The text was updated successfully, but these errors were encountered: