Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement essl_colorized_low_level_moisture using colorize #3020

Open
gerritholl opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3021
Open

Re-implement essl_colorized_low_level_moisture using colorize #3020

gerritholl opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3021

Comments

@gerritholl
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe.

The composite essl_colorized_low_level_moisture is currently implemented using a dedicated enhancement class in satpy.enhancements.atmosphere.py:

def essl_moisture(img, low=1.1, high=1.6) -> None:

However, this does nothing else than calculating a colormap. Therefore, this could be some simply defined using colorize. This would be easier to maintain or modify. Moreover, the current enhancement function only works for mode L input data, not LA, and can therefore not be used with input coming from MaskingCompositor. This makes it hard to overlay a cloud mask or a land/water mask. Another problem is that the ratio is defined the opposite way compared to the original design by Hans-Peter Roesli.

Describe the solution you'd like

I would like to re-implement essl_colorized_low_level_moisture as a RatioCompositor with a colorize enhancement.

Describe any changes to existing user workflow

This will break any user's workflow that relies on the essl_moisture function being present.

Additional context

An alternative would be to adapt the essl_low_level_moisture function to work with LA input data, but this would only solve part of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant