Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some borders missing from area images #2951

Open
gerritholl opened this issue Oct 24, 2024 · 2 comments
Open

Some borders missing from area images #2951

gerritholl opened this issue Oct 24, 2024 · 2 comments

Comments

@gerritholl
Copy link
Member

Describe the bug

For some areas in the area definitions included in satpy, some borders are missing.

To Reproduce

Expected behavior

All internationally recognised borders should be drawn.

Actual results / Screenshots

Poland, Norway, and SADR are gone.

Bildschirmfoto_2024-10-24_10-10-52

Czechia and Austria have a dangling border, but are otherwise, along with France and Italy, absorbed in a monster state:

Bildschirmfoto_2024-10-24_10-11-50

Environment Info:

  • OS: openSUSE 15.3
  • Firefox Version: 118.0.2
@djhoese
Copy link
Member

djhoese commented Oct 24, 2024

Can't you ever file bug reports for easy to fix things? 😜

So I'm pretty sure I've seen something like this before and my guess it is related to the resolution of the borders being used and maybe some matplotlib/bokeh stuff deciding not to draw lines that are "too small". I could try generating them locally with the full resolution borders and see what happens.

@djhoese
Copy link
Member

djhoese commented Oct 24, 2024

This is not better:

diff --git a/doc/source/generate_area_def_list.py b/doc/source/generate_area_def_list.py
index 2c5d8d17b..e552835f7 100644
--- a/doc/source/generate_area_def_list.py
+++ b/doc/source/generate_area_def_list.py
@@ -132,7 +132,7 @@ def _generate_html_map_divs(areas_dict: dict) -> tuple[str, dict]:
             continue
         crs = area_def.to_cartopy_crs()
 
-        features = gv.Overlay([gf.ocean, gf.land, gf.borders, gf.coastline])
+        features = gv.Overlay([gf.ocean, gf.land, gf.borders.geoms('10m'), gf.coastline])
         f = gv.render(
             features.opts(
                 toolbar=None,

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants