Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpha band improvement for DayNightCompositor #2357

Closed
yukaribbba opened this issue Jan 19, 2023 · 2 comments · Fixed by #2358
Closed

Alpha band improvement for DayNightCompositor #2357

yukaribbba opened this issue Jan 19, 2023 · 2 comments · Fixed by #2358
Assignees
@yukaribbba
Labels
component:compositors enhancement code enhancements, features, improvements

Comments

@yukaribbba
Copy link
Contributor

yukaribbba commented Jan 19, 2023 •
edited
Loading

Feature Request

Is your feature request related to a problem? Please describe.
Under "day/night only" mode, an alpha band will be added to the output image for transparency, even if I set fill_value=0 in geotiff. However, sometimes I just want a single-band image with masked-out area, like the right one below.
image

Describe the solution you'd like
Add an argument to the compositor to switch alpha band on/off.

I'll start a PR for this.
@yukaribbba yukaribbba mentioned this issue Jan 19, 2023
Merged
3 tasks
@mraspaud
Copy link
Member

Thanks for reporting this issue. Do I understand correctly that you are not interested in space as a background, you just want black instead?

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:compositors labels Jan 19, 2023
@yukaribbba
Copy link
Contributor Author

Thanks for reporting this issue. Do I understand correctly that you are not interested in space as a background, you just want black instead?

Yep.

@gerritholl gerritholl mentioned this issue Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yukaribbba yukaribbba

Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an argument to the compositor to switch alpha band on/off in DayNightCompositor
2 participants
@mraspaud @yukaribbba