Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against xarray master #1059

Closed
dcherian opened this issue Feb 4, 2020 · 3 comments · Fixed by #1095
Closed

test against xarray master #1059

dcherian opened this issue Feb 4, 2020 · 3 comments · Fixed by #1095
Labels
enhancement code enhancements, features, improvements

Comments

@dcherian
Copy link

dcherian commented Feb 4, 2020

It'd be nice if satpy and other relevant pytroll projects could run CI with xarray's master branch so we can catch bugs like pydata/xarray#3746 and #1058 earlier.

We test against master branches of dask etc like this:
https://github.com/pydata/xarray/blob/4c96d53e6caa78d56b785f4edee49bbd4037a82f/ci/azure/install.yml#L13-L34

@djhoese
Copy link
Member

djhoese commented Feb 4, 2020

As an add on to this, we should probably start failing on warnings in at least one environment (specified as an allowed failure).

@mraspaud
Copy link
Member

mraspaud commented Feb 5, 2020

@dcherian thanks for bringing this up. I think it's a good idea, we will discuss it and see how we can modify .travis.yml to include the master branches of xarray, dask, rasterio...

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Feb 5, 2020
@djhoese
Copy link
Member

djhoese commented Mar 2, 2020

As pointed out in the various related PRs, this has already helped point out an issue with how our trollimage project is using expand_dims and copying the data. Thanks @dcherian for suggesting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants