Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coveralls reporting from github actions #328

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 3, 2021

Coveralls keeps reporting 0. It may be that it expects a certain file format to be generated. This PR is me figuring it out.

@djhoese djhoese self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #328 (e481db3) into master (23e78a6) will decrease coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   92.74%   91.29%   -1.45%     
==========================================
  Files          44       45       +1     
  Lines        9226     9505     +279     
==========================================
+ Hits         8557     8678     +121     
- Misses        669      827     +158     
Flag Coverage Δ
unittests 91.29% <ø> (-1.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/version.py 43.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e78a6...a6e2a07. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 3, 2021

Coverage Status

Coverage increased (+91.2%) to 91.239% when pulling a6e2a07 on djhoese:ci-cov-fix into 23e78a6 on pytroll:master.

@djhoese djhoese merged commit 3acb6aa into pytroll:master Feb 3, 2021
@djhoese djhoese deleted the ci-cov-fix branch February 3, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants