Feature lac #5
Closed
Feature lac #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Raspaud <[email protected]>
Conflicts: pygac/gac_klm.py pygac/gac_pod.py pygac/reader.py Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
Signed-off-by: Martin Raspaud <[email protected]>
sfinkens
reviewed
Feb 15, 2017
| tle1, tle2 = self.get_tle_lines() | ||
|
|
||
| scan_points = np.arange(3.5, 2048, 5) | ||
|
|
||
| if utcs is None: | ||
| utcs = self.get_times() |
There was a problem hiding this comment.
The origin of the timestamp mismatch between feature-lac and develop is here: get_times() returns a reference to self.utcs, so that decrementing utcs below (utcs -= ...) actually modifies self.utcs. I don't know whether this is intended or not. But I guess it is not, because each time compute_lonlat() is called, self.utcs changes its value. Using a local copy utcs = self.get_times().copy() resolves the timestamp mismatch. However, lat/lon is still different compared to the develop branch. The problem does not occur in the develop branch, because compute_lonlat() is never called with utcs=None.
There was a problem hiding this comment.
Thanks for pointing this out. I will have a closer look.
mraspaud
pushed a commit
that referenced
this pull request
Mar 19, 2019
…canline-timestamp Fix travis build
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor pygac to merge common gac and lac parts.