Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nameserver script again #71

Closed
wants to merge 4 commits into from

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Jan 28, 2025

After the recent merged PRs the nameserver script is no more installed and available. This PR seeks to solve this glitch.

Adam.Dybbroe added 4 commits January 27, 2025 18:20
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Signed-off-by: Adam.Dybbroe <[email protected]>
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (87962f3) to head (3fd6a7a).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
posttroll/nameserver.py 0.00% 9 Missing ⚠️
posttroll/address_receiver.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   89.59%   87.08%   -2.52%     
==========================================
  Files          25       26       +1     
  Lines        2278     2338      +60     
==========================================
- Hits         2041     2036       -5     
- Misses        237      302      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adybbroe adybbroe requested a review from mraspaud January 28, 2025 14:24
@adybbroe adybbroe self-assigned this Jan 28, 2025
@adybbroe adybbroe added the bug label Jan 28, 2025
@adybbroe adybbroe changed the title Make nameserver great again Include nameserver script again Jan 29, 2025
@mraspaud mraspaud closed this in #72 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant