Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and Document the io.image enhancements #3034

Closed
4 tasks done
datumbox opened this issue Nov 19, 2020 · 2 comments · Fixed by #3193
Closed
4 tasks done

Clean up and Document the io.image enhancements #3034

datumbox opened this issue Nov 19, 2020 · 2 comments · Fixed by #3193

Comments

@datumbox
Copy link
Contributor

datumbox commented Nov 19, 2020

PR #3024 introduced a few enhancements on the io.image methods used for reading JPEG and PNG images. The code changes were merged but there are a few nice-to-have improvements missing.

More specifically:

  • Provide better error messages for JPEG and PNG when a specific ImageReadMode value is not supported.
  • Ensure that image_read_mode.h has a new line at the end of the file.
  • Replace the old #define with the newer constexpr expression at image_read_mode.h.
  • Move the documentation of ImageReadMode values from the methods to the enum.

Note: constexpr might cause problems on Windows. If that's the case, try using const instead.

@Sid2697
Copy link
Contributor

Sid2697 commented Dec 18, 2020

Hey! I was wondering if I could contribute to this issue, is there anyone already working on it?

@datumbox
Copy link
Contributor Author

Hey @Sid2697, welcome!

Go for it. Looking forward to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants