Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with python < 3.10 #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compatibility with python < 3.10 #170

wants to merge 1 commit into from

Conversation

vmoens
Copy link

@vmoens vmoens commented Mar 7, 2024

Closes #169

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2024
@facebook-github-bot
Copy link
Contributor

@galrotem has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

galrotem
galrotem approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@galrotem galrotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and apologies for the noise

@vmoens
Copy link
Author

vmoens commented Mar 7, 2024

I don't think I linted this sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galrotem galrotem galrotem approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torchsnapshot nightlies / torch nightlies are broken on python < 3.10
3 participants
@vmoens @facebook-github-bot @galrotem