Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MACOSX_DEPLOYMENT_TARGET #1728

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented May 17, 2022

Reference Issue: #1725
Reference PR: pytorch/audio#1880

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@parmeet parmeet merged commit 03b8a05 into pytorch:main May 17, 2022
@parmeet parmeet deleted the mac_os_target branch May 17, 2022 13:34
facebook-github-bot pushed a commit to pytorch/data that referenced this pull request May 18, 2022
Summary:
- Change target platform to manylinux2014 for linux (See workflow: https://github.com/pytorch/data/runs/6479078172?check_suite_focus=true#step:9:87)
  - `manylinux_2_17_x86_64` is an alias of `manylinux2014`
  - See [PEP600](https://peps.python.org/pep-0600/)
- Re-enable MacOS binary with AWSSDK after pytorch/text#1728 is landed.

See workflow: https://github.com/pytorch/data/actions/runs/2341532489

Pull Request resolved: #415

Reviewed By: NivekT, bearzx

Differential Revision: D36460356

Pulled By: ejguan

fbshipit-source-id: 9aa349aba2e5e1a5073f7be27f4ae8466bc8ce7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants