-
Notifications
You must be signed in to change notification settings - Fork 22.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip package URL is not a valid index #39779
Comments
cc @soumith who I think originally set this up. |
yea, @seemethere we should fix this. cc: @malfet |
RElated: #25639 |
This could resolve a number of issues filed against pipenv pypa/pipenv#4649 Clear answer from the pipenv team at pypa/pipenv#4649 (comment) See also: pytorch/builder#615 |
Bumping priority as this trips up quite a few users. |
Any updates on this thus far? |
Would maintaining two indexes be acceptable (standard and non-standard)? |
This has already been resolved see #25639 (comment), closing. |
Thanks a lot for creating that PEP 503 repo! If anyone needs the correct solution for installing PyTorch via Pipenv, I have posted a guide and explanation here:It would be cool if the official pytorch website could list those install commands (the ones I've generated) as an option during the "roll your own selections" guide. I.e. having Pipenv as a choice next to Pip, and then showing the command-style that I'm using in my guide. Then projects that are based on Pipenv won't have to manually lookup the latest versions in the repo HTML in a browser anymore. |
🐛 Bug
The URL presented on the Getting Started page (
https://download.pytorch.org/whl/torch_stable.html
) is not a valid index (i.e. the "simple" format). This means package managers like Poetry and Pipenv can't consume the packages.Right now it works with pip because pip can search arbitrary HTML pages for download links that look like they lead to python packages. However, there are assumptions about the format in package managers like Poetry and Pipenv.
We work around this issue by mirrorring the packages in an index of our own but it seems like it would be much friendlier to users if this would be solved at your end.
I get that it may not matter much for "quick start" setups where you just want it to work on your machine, but it's a bigger problem in production deployments where reproducibility matters and thus lockfiles and dependency management are of greater importance.
PEP 503 -- Simple Repository API specifies the simple format, it only requires a couple of minor changes to the HTML you currently serve.
Edit The relevant code seems to be https://github.com/pytorch/builder/blob/master/cron/update_s3_htmls.sh
which is another repo, so perhaps the issue should be transferred?
To Reproduce
Steps to reproduce the behavior:
pyproject.toml
poetry lock -vvv
cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @anjali411 @seemethere @malfet @walterddr
The text was updated successfully, but these errors were encountered: