-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Auto register Configs upon import of hydra_configs.module.name #53
Comments
I don't think we need to call them automatically.
|
Don't the users have control by determining which 'module' they import? What was your alternative proposition? |
Users may import the packages to use the config objects directly as well. import hydra_configs.pytrorch
#register everything under pytorch
hydra_configs.pytrorch.register()
#register everything under pytorch.optim
hydra_configs.pytrorch.optim.register() |
Ok, I think this is probably a better option. The automatic strategy would likely leave users confused about what is and what isnt currently registered. Better to be explicit and convenient. |
we can make register at the top level mean recursive to make things convenient. |
Write functions of the form:
hydra_configs.torch.register()
,hydra_configs.torch.optim.register()
, etc.Within these functions, call config store API:
Call these in
__init__.py
for the module.The text was updated successfully, but these errors were encountered: