Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hydra-configs-torch][tests] Optimizers and LR schedulers #2

Open
romesco opened this issue Sep 26, 2020 · 1 comment
Open

[hydra-configs-torch][tests] Optimizers and LR schedulers #2

romesco opened this issue Sep 26, 2020 · 1 comment

Comments

@romesco
Copy link
Contributor

romesco commented Sep 26, 2020

https://github.com/facebookresearch/hydra-torch/blob/691a390abd2edf764f9431a56b8058ff2c12eb0c/tests/test_instantiate.py#L40

Check minimal tests. Is this the right way to confirm our configs instantiate the correct object?

From previous PR discussion:

Ideally I wanted these tests to do 3 things:

  1. Ensure the config exists.
  2. Be a valid input to instantiate (and subsequently get an object back).
  3. Show that this object works as expected.

For an optimizer, taking a step seems to prove that it is functioning correctly. Comparing the output of your cfg optimizer and a directly called optimizer is kind of a bonus in that if it didn't work, it doesn't mean we didn't instantiate an optimizer correctly given the config. It just means the optimizer has nondeterministic behavior.

@romesco
Copy link
Contributor Author

romesco commented Oct 15, 2020

Need to complete LR schedulers as well.

@romesco romesco changed the title torch/optim tests [hydra-torch-configs][tests] Optimizers and LR schedulers Dec 19, 2020
@romesco romesco changed the title [hydra-torch-configs][tests] Optimizers and LR schedulers [hydra-configs-torch]tests] Optimizers and LR schedulers Dec 19, 2020
@romesco romesco changed the title [hydra-configs-torch]tests] Optimizers and LR schedulers [hydra-configs-torch][tests] Optimizers and LR schedulers Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant