Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable arg{max,min}: optimize update check #8755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

We don't need a second isnan; see code comment. (This is a small optimization.)

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 27, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Feb 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8755

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c9bd251 with merge base afcec1d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
swolchok added a commit that referenced this pull request Feb 27, 2025
We don't need a second isnan; see code comment. (This is a small optimization.)

ghstack-source-id: 04c7bc552a5c83c84d209dbc70b8d17310916466
ghstack-comment-id: 2686527528
Pull Request resolved: #8755
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants