Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for splitting in_features in linear layers #8715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Feb 26, 2025

This PR:

  • Moves SplitLinearModule to a separate utils.py and extends it to support splitting in_features. I did not find splitting in_features worked very well, at least in my initial experiments.
  • Updates readme with latest setting recommendations for Llama1B

Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8715

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 47f0c44 with merge base 5a594a7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@metascroy metascroy requested review from YifanShenSZ and cccclai and removed request for cccclai February 26, 2025 01:27
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants