-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tile dynamo converter #2402
Conversation
557cb25
to
58c8f2f
Compare
shapes = [] | ||
for i, (s, d) in enumerate(zip(input.shape, dims)): | ||
shapes.append( | ||
impl.elementwise.mul(ctx, target, source_ir, f"{name}_mul_{i}", s, d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this part, if in the function definition the dims is Sequence[int]?
I am assuming it is for the case where the dims is a sequence of ITensors? Then accordingly maybe the function definition needs to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the else
part is not needed. Thanks for comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a minor clarification I wanted, in this I see that dims are SymInt[] so that should be fine for int based arithmetic operations right?
Hi - generally |
Hi, in the tests we pass in |
In that case, we should be typing everything with |
d4a83ac
to
222902d
Compare
222902d
to
4d71e91
Compare
Description
Support
tile
dynamo converter. This is a part ofslice
converter.Fixes part of #2215
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: